Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on a deprecated package #119

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Remove dependency on a deprecated package #119

merged 1 commit into from
Oct 4, 2022

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 23, 2022

Proposed changes

Replace deprecated package io/ioutil with io

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested review from lucacome, ciarams87, a team and shaun-nx September 23, 2022 10:17
@jjngx jjngx added the chore Pull requests for routine tasks label Sep 27, 2022
@jjngx jjngx requested review from a team and removed request for a team September 27, 2022 11:20
@jjngx jjngx requested a review from a team October 3, 2022 08:57
@lucacome lucacome merged commit 3c86686 into main Oct 4, 2022
@lucacome lucacome deleted the dependencies-fix branch October 4, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@vepatel vepatel vepatel approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjngx @lucacome @vepatel