Quic: prevent invalid stream frame retransmissions #230
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arut
force-pushed
the
ignore_invalid_stream_frame
branch
from
6f44705 to
4ab1fda
Compare
arut
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Quic: prevent invalid stream frame retransmissions
Please change the prefix to QUIC: and add a dot at the end.
One possible scenario how this can happen is when a RESET_STREAM was sent by nginx and received by the client. Then the stream was deleted. After that one of prior STREAM frames was lost and retransmitted. While this does not look like something terrible, RFC 9000 explicitly prohibits this in Section 19.4:
After sending a RESET_STREAM, an endpoint ceases transmission and retransmission of STREAM frames on the identified stream.
I suggest the following commit message:
QUIC: prevent deleted stream frame retransmissions.
Since [1], stream frames no longer need to be retransmitted after it was deleted.
The frames which were retransmitted before, could be stream data frames sent prior
to a RESET_STREAM. Such retransmissions are explicitly prohibited by RFC 9000,
Section 19.4.
[1] https://github.com/nginx/nginx/commit/a2a513b93caeba13e408bfc80f8626f49550be40
src/event/quic/ngx_event_quic_ack.c
Outdated
Comment on lines
638
to
639
| ngx_quic_free_frame(c, f); | ||
| break; |
nandsky
force-pushed
the
ignore_invalid_stream_frame
branch
from
4ab1fda to
15adc0d
Compare
|
@arut thanks and I have addressed the review comments. |
Since a2a513b, stream frames no longer need to be retransmitted after it was deleted. The frames which were retransmitted before, could be stream data frames sent prior to a RESET_STREAM. Such retransmissions are explicitly prohibited by RFC 9000, Section 19.4.
arut
force-pushed
the
ignore_invalid_stream_frame
branch
from
15adc0d to
b17573b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to resend stream frames if the corresponding stream has already been closed.