Feature/implements discoverable search provider #9053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
added
3. to review
feature: api 🛠️
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feature/implements-discoverable-search-provider
branch
from
442aba3
to
f0aa0e9
Compare
|
/backport to stable26 |
julien-nc
requested changes
Mar 13, 2023
There was a problem hiding this comment.
👍 Except icon-file-white should be icon-text-white in https://github.com/nextcloud/spreed/blob/master/lib/Search/ConversationSearch.php#L133.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
Mar 14, 2023
julien-nc
requested changes
Mar 14, 2023
This is what's display in the provider list #9053 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>
julien-nc
approved these changes
Mar 14, 2023
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
This is what's display in the provider list #9053 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>
|
You bumped the vue library in Talk @vitormattos ? |
1 task
@nickvergessen the bump is here: #9086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🏁 Checklist
docs/has been updated or is not required