Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate and replace legacy jQuery UI dialogs with Vue #44755

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 9, 2024

Summary

Remove and replace legacy jQuery UI dialogs with Vue alternative.

TODO

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Apr 9, 2024
@susnux susnux changed the title Feat/deprecate and replace j query dialogs feat: Deprecate and replace legacy jQuery UI dialogs with Vue Apr 9, 2024
@susnux susnux force-pushed the feat/deprecate-and-replace-jQuery-dialogs branch 2 times, most recently from ba4e5b0 to c66040b Compare April 9, 2024 17:45
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but code looks sane

Good stuff 👏

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…loud/dialogs` alternative

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/deprecate-and-replace-jQuery-dialogs branch from c66040b to 5088cbc Compare April 10, 2024 11:54
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! :)

@susnux susnux enabled auto-merge April 10, 2024 13:54
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 28a30a6 into master Apr 10, 2024
126 checks passed
@susnux susnux deleted the feat/deprecate-and-replace-jQuery-dialogs branch April 10, 2024 19:56
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants