Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded margin after paragraphs #39066

Conversation

JuliaKirschenheuter
Copy link
Contributor

Summary

Before After
user status user status2

Works with:

  • Check Dashboard widgets with ARCToolkit
  • Check Dashboard widgets with Text spacing editor

Checklist

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fix might need to be done on the @nc/vue side.
Either remove that <p>, or force no margin on it.

@JuliaKirschenheuter
Copy link
Contributor Author

I think the fix might need to be done on the @nc/vue side. Either remove that <p>, or force no margin on it.

I'm not sure about all other widgets. With NcVue change there is a risk to break something i can't see now. Should i?

@solracsf solracsf added this to the Nextcloud 28 milestone Jul 2, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

PR was moved to Nc Vue: nextcloud-libraries/nextcloud-vue#4297

@skjnldsv skjnldsv deleted the fix/39064-_BITV]_9.1.4.12/2.2_-_When_text_spacing_is_increased,_the_contents_of_the_Recent_statuses_tile_become_inaccessible branch March 14, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
3 participants