Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mess with @nextcloud/vue styles and fix navigation header a11y #2290

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 26, 2024

The real problem for that issue is that photos messes with the app navigation button.
Also fixing the overall accessibility of the header bar on small devices, currently it overflows the screen.
Including the new album button to have different aria-label compared to button text, for small mobile devices we need a icon only button to not overflow.

Screenshots

before after
Screen Shot 2024-01-26 at 17 52 48 Screen Shot 2024-01-26 at 17 52 25
Screen Shot 2024-01-26 at 17 51 20 Screen Shot 2024-01-26 at 17 51 07
Screen Shot 2024-01-26 at 17 49 30 Screen Shot 2024-01-26 at 17 50 59

…ake navigation accessible

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility labels Jan 26, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/header-navigation-styling branch from 6ca9e47 to a4461e2 Compare January 26, 2024 17:06
@artonge artonge merged commit 0e8a81f into master Jan 29, 2024
23 checks passed
@artonge artonge deleted the fix/header-navigation-styling branch January 29, 2024 10:00
@JuliaKirschenheuter
Copy link
Contributor

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 2, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Feb 2, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Not possible to close left sidebar on small screens
3 participants