Fix doubling attrs in NcPopover and improve docs
#3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `inheritAttrs: false` to prevent attrs doubling - Add props passing example to the docs Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
ShGKme
added
bug
raimund-schluessler
approved these changes
Mar 10, 2023
mejo-
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem
NcPopoveris a wrapper aroundfloating-vue'sDropdowncomponent. It proxies all attrs and listeners to the wrapped Dropdown. It allows setting anyDropdown's props for customization.But Vue inherits all attrs on the root node by default. It makes all attrs, passed as Dropdown prop, set as HTML attrs of root div.
Expected behavior with the
DropdownpropsActual behavior
The solution
This PR adds the required
inheritAttrs: false.ESLint rule helping with this problem: https://eslint.vuejs.org/rules/no-duplicate-attr-inheritance.html
Docs improvements
DropdownSee commits for details 馃