Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doubling attrs in NcPopover and improve docs #3876

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Fix doubling attrs in NcPopover and improve docs #3876

merged 3 commits into from
Mar 22, 2023

Commits on Mar 10, 2023

  1. fix(NcPopover): fix attrs doubling 

    - Add `inheritAttrs: false` to prevent attrs doubling
- Add props passing example to the docs
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
    @ShGKme
    ShGKme committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ab030ac View commit details
    Browse the repository at this point in the history

  2. docs(NcPopover): fix typos 

    Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
    @ShGKme
    ShGKme committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e307ffd View commit details
    Browse the repository at this point in the history

  3. docs(NcPopover): fix Popover positions in examples 

    Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
    @ShGKme
    ShGKme committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    56ddd3a View commit details
    Browse the repository at this point in the history