Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add collapsible submissions view #1560

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Mar 15, 2023

This is still work in progress as there are a few questions for which I would like to have some feedback:

  • Currently there is a "unread" notification, to have this work across browser sessions we would have to save it on the back end, so:
    • Do we want this feature? (I would like to have it as it allows better overview on already processed responses)
    • One global "viewed" flag per submission or one per user? (I would prefer it per user)
    • Saved within the submission? Or in the share? Or a new table? Somewhere else?
  • I implemented this currently as a separate view, should we keep this as a third view or replace the "responses" view with this?

Here is a screen recording on how it looks like currently:

screenrecording.mp4

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux added enhancement New feature or request 2. developing Work in progress design Related to the design feature: 📊 responses & statistics labels Mar 15, 2023
@susnux susnux marked this pull request as draft March 15, 2023 16:02
@Chartman123
Copy link
Collaborator

  • Currently there is a "unread" notification, to have this work across browser sessions we would have to save it on the back end, so:
    • Do we want this feature? (I would like to have it as it allows better overview on already processed responses)

Unread flag would be nice, this could also be represented in the list of forms on the left

  • One global "viewed" flag per submission or one per user? (I would prefer it per user)

I would say that it's enough to have it per submission, but per user would be nice

  • Saved within the submission? Or in the share? Or a new table? Somewhere else?

Depends on the point above... If per submission, then with the submission. If per user, probably somewhere else

  • I implemented this currently as a separate view, should we keep this as a third view or replace the "responses" view with this?

A separate view isn't necessary in my opinion... We're showing the same information as in the responses view. So in conjunction with the "unread" flag you could for example collapse all read submissions by default and have a collapse/expand all action on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design Related to the design enhancement New feature or request feature: 📊 responses & statistics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make responses collapsible
2 participants