Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use php-cs-fixer/shim #13

Merged
merged 1 commit into from Jun 1, 2023
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 30, 2023

php-cs-fixer/shim is php-cs-fixer as compiled phar.

php-cs-fixer has a couple of peer dependencies. There is a chance that a php-cs-fixer dependency may conflict with our dependencies.

Before:

composer info
composer/pcre                      3.1.0   PCRE wrapping library that offers type-safe preg_* replacements.
composer/semver                    3.3.2   Semver library that offers utilities, version constraint parsing and valida...
composer/xdebug-handler            3.0.3   Restarts a process without Xdebug.
doctrine/annotations               2.0.1   Docblock Annotations Parser
doctrine/lexer                     3.0.0   PHP Doctrine Lexer parser library that can be used in Top-Down, Recursive D...
friendsofphp/php-cs-fixer          v3.17.0 A tool to automatically fix PHP code style
psr/cache                          3.0.0   Common interface for caching libraries
psr/container                      2.0.2   Common Container Interface (PHP FIG PSR-11)
psr/event-dispatcher               1.0.0   Standard interfaces for event handling.
psr/log                            3.0.0   Common interface for logging libraries
sebastian/diff                     5.0.3   Diff implementation
symfony/console                    v6.2.11 Eases the creation of beautiful and testable command line interfaces
symfony/deprecation-contracts      v3.2.1  A generic function and convention to trigger deprecation notices
symfony/event-dispatcher           v6.2.8  Provides tools that allow your application components to communicate with e...
symfony/event-dispatcher-contracts v3.2.1  Generic abstractions related to dispatching event
symfony/filesystem                 v6.2.10 Provides basic utilities for the filesystem
symfony/finder                     v6.2.7  Finds files and directories via an intuitive fluent interface
symfony/options-resolver           v6.2.7  Provides an improved replacement for the array_replace PHP function
symfony/polyfill-ctype             v1.27.0 Symfony polyfill for ctype functions
symfony/polyfill-intl-grapheme     v1.27.0 Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-normalizer   v1.27.0 Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring          v1.27.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php80             v1.27.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions
symfony/polyfill-php81             v1.27.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions
symfony/process                    v6.2.11 Executes commands in sub-processes
symfony/service-contracts          v3.2.1  Generic abstractions related to writing services
symfony/stopwatch                  v6.2.7  Provides a way to profile code
symfony/string                     v6.2.8  Provides an object-oriented API to strings and deals with bytes, UTF-8 code...

After:

composer info
php-cs-fixer/shim v3.17.0 A tool to automatically fix PHP code style

php-cs-fixer has a couple of peer dependencies. There is a chance that a php-cs-fixer dependency may conflict with our own dependencies.

php-cs-fixer/shim is php-cs-fixer as compiled phar.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@ChristophWurst
Copy link
Member

The repos I touch all use https://packagist.org/packages/bamarni/composer-bin-plugin. Are there repos that use the cs fixer as direct (dev) dependency?

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving into this. 🙇🏼‍♂️

So we need a new release after this?

@nickvergessen nickvergessen merged commit 55def70 into master Jun 1, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-php-cs-fixer-shim branch June 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants