Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichText): adjust display so long texts in checkboxes can be shown correctly #5527

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(NcRichText): adjust display so long texts in checkboxes can be shown correctly #5527

merged 1 commit into from
Apr 26, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Apr 25, 2024 •
edited by Antreesy

☑️ Resolves

At least for checkboxes in RichText, it makes sense to have inline display.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad added bug Something isn't working feature: richtext Related to the richtext component labels Apr 25, 2024
@DorraJaouad DorraJaouad self-assigned this Apr 25, 2024
@DorraJaouad DorraJaouad changed the title fix(NcRichText): adjust display so long texts can be shown correctly fix(NcRichText): adjust display so long texts in checkboxes can be shown correctly Apr 25, 2024
@Antreesy
Copy link
Contributor

Maybe it should be fixed directly in the component, rather than using 'deep'?

@ShGKme
Copy link
Contributor

ShGKme commented Apr 25, 2024

Maybe it should be fixed directly in the component, rather than using 'deep'?

I wonder why checkbox text is a flex container in first place...

@DorraJaouad
fix: adjust display for content
2ef656b 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
Copy link
Contributor Author

Maybe it should be fixed directly in the component, rather than using 'deep'?

Well, I thought it should remain as a flex container for some reason . It was added to center text vertically (#5151)

I moved it to the specific checkbox type that needs it.

Antreesy
Antreesy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, compared with https://nextcloud-vue-components.netlify.app.

Looks like a decent solution for now

@Antreesy Antreesy requested a review from susnux April 26, 2024 01:04
@Antreesy Antreesy added this to the 8.11.3 milestone Apr 26, 2024
@Antreesy Antreesy added the 3. to review Waiting for reviews label Apr 26, 2024
@Antreesy
Copy link
Contributor

/backport to next

@DorraJaouad DorraJaouad merged commit 3febf1b into master Apr 26, 2024
18 checks passed
@DorraJaouad DorraJaouad deleted the fix/long-text-checkboxes branch April 26, 2024 14:06
@backportbot backportbot bot mentioned this pull request Apr 26, 2024
Merged
@Antreesy Antreesy mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
Milestone
8.11.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DorraJaouad @Antreesy @ShGKme