Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcActionInput): Add label to sample #5432

Merged
merged 1 commit into from Mar 21, 2024

Conversation

nickvergessen
Copy link
Contributor

☑️ Resolves

Before https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactioninput yields an error in the console and leads to bad examples:

Bildschirmfoto vom 2024-03-21 11-20-45

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews labels Mar 21, 2024
@nickvergessen nickvergessen added this to the 8.11.1 milestone Mar 21, 2024
@nickvergessen nickvergessen self-assigned this Mar 21, 2024
@nickvergessen
Copy link
Contributor Author

/backport to next

@Antreesy
Copy link
Contributor

Antreesy commented Mar 21, 2024

having labels in examples is good, but they're not passed to the NcSelect as inputLabel

Although NcActionInput should accept it as attribute and propagate to child component, that is not the best way, as you should check the code and guess, which props are needed, and which you should look up in another component documentation

mounted() {
if (!this.labelOutside && !this.inputLabel && !this.ariaLabelCombobox) {
Vue.util.warn('[NcSelect] An `inputLabel` or `ariaLabelCombobox` should be set. If an external label is used, `labelOutside` should be set to `true`.')
}
if (this.inputLabel && this.ariaLabelCombobox) {
Vue.util.warn('[NcSelect] Only one of `inputLabel` or `ariaLabelCombobox` should to be set.')
}
},

@nickvergessen
Copy link
Contributor Author

but they're not passed to the NcSelect as inputLabel

Both worked in a local test (as in showed up), but yeah I seem to have missed that the console error is now back when I moved from input-label to label

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/add-missing-label-to-sample branch from 5af97ac to d5ca877 Compare March 21, 2024 11:16
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy merged commit 0b7a6ff into master Mar 21, 2024
18 checks passed
@Antreesy Antreesy deleted the bugfix/noid/add-missing-label-to-sample branch March 21, 2024 12:03
@Antreesy Antreesy mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants