Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem): decrease font-weight, restore contrast color for subname #5421

Merged
merged 1 commit into from Mar 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 19, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
Talk --
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…name

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Mar 19, 2024
@Antreesy Antreesy added this to the 8.11.1 milestone Mar 19, 2024
@Antreesy Antreesy self-assigned this Mar 19, 2024
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! :)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on mail

@Antreesy Antreesy merged commit 0125a4a into master Mar 19, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/noid/lighter-list-item branch March 19, 2024 15:40
@Antreesy Antreesy mentioned this pull request Mar 21, 2024
@susnux
Copy link
Contributor

susnux commented Apr 9, 2024

/backport to next

Copy link

backportbot bot commented Apr 9, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5421/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 585b5202

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5421/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants