Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tribute): provide avatar url correctly when in dark mode #5420

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix(tribute): provide avatar url correctly when in dark mode #5420

merged 1 commit into from Mar 19, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 19, 2024 •
edited by susnux

☑️ Resolves

  • Fix wrong user avatar colors in dark mode for autocomplete rendered components

🖼️ Screenshots

🏚️ Before 🏡 After
image Screenshot from 2024-03-19 11-00-59
image Screenshot from 2024-03-19 11-00-48

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(tribute): provide avatar url correctly when in dark mode
b532af4 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 19, 2024
@Antreesy Antreesy added this to the 8.11.1 milestone Mar 19, 2024
@Antreesy Antreesy self-assigned this Mar 19, 2024
@Antreesy Antreesy merged commit f953b48 into master Mar 19, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/noid/tribute-dark-mode branch March 19, 2024 12:44
@Antreesy Antreesy mentioned this pull request Mar 21, 2024
Merged
@susnux
Copy link
Contributor

susnux commented Apr 9, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.11.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Antreesy @susnux @ShGKme