Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAvatar): rendering user status emoji in the menu #5409

Merged
merged 1 commit into from Mar 15, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 15, 2024

☑️ Resolves

🖼️ Screenshots

To test - add icon to the icon property.

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Mar 15, 2024
@ShGKme ShGKme added this to the 8.10.1 milestone Mar 15, 2024
@ShGKme ShGKme self-assigned this Mar 15, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/NcAvatar--user-status-icon-in-contacts-menu branch from 23f371e to 38253ae Compare March 15, 2024 15:08
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
image

@susnux susnux merged commit 2efe99c into master Mar 15, 2024
18 checks passed
@susnux susnux deleted the fix/NcAvatar--user-status-icon-in-contacts-menu branch March 15, 2024 16:17
@Antreesy
Copy link
Contributor

/backport to next

@ShGKme ShGKme added the bug Something isn't working label Mar 15, 2024
@ShGKme ShGKme modified the milestones: 8.10.1, 8.11.0 Mar 15, 2024
@Antreesy Antreesy mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New avatar menu has wrong icon colors in dark mode
4 participants