Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppSidebar): animation glitch on toggle #5389

Merged
merged 1 commit into from
Mar 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/NcAppNavigation/NcAppNavigation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ export default {
transition: transform var(--animation-quick), margin var(--animation-quick);
width: $navigation-width;
// Left toggle button padding + toggle button + right padding from NcAppContent
max-width: calc(100vw - (var(--app-navigation-padding) + var(--default-clickable-area) + var(--default-grid-baseline)));
--app-navigation-max-width: calc(100vw - (var(--app-navigation-padding) + var(--default-clickable-area) + var(--default-grid-baseline)));
max-width: var(--app-navigation-max-width);
position: relative;
top: 0;
left: 0;
Expand All @@ -252,13 +253,12 @@ export default {
user-select: none;
flex-grow: 0;
flex-shrink: 0;
background-color: var(--color-main-background-blur, var(--color-main-background));
background-color: var(--color-main-background-blur, var(--color-main-background));
-webkit-backdrop-filter: var(--filter-background-blur, none);
backdrop-filter: var(--filter-background-blur, none);
&--close {
transform: translateX(-100%);
position: absolute;
margin-left: calc(-1 * min($navigation-width, var(--app-navigation-max-width)));
}
// For legacy purposes support passing a bare list to the content in #default slot and including #footer slot
Expand Down Expand Up @@ -303,7 +303,7 @@ export default {
// When on mobile, we make the navigation slide over the appcontent
@media only screen and (max-width: $breakpoint-mobile) {
.app-navigation:not(.app-navigation--close) {
.app-navigation {
position: absolute;
}
}
Expand Down