Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcActions): focus first checked item on open #5313

Merged
merged 1 commit into from Feb 27, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 26, 2024

☑️ Resolves

IMO, this should happen only when ALL the buttons are one radio button group. But it is required even for heading in Text, where we have "Show outline" button together with heading radio buttons.

The solution is still not reliable, but I don't see any other simple solution...

🖼️ Screenshots

focus-first-action

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components regression Regression of a previous working feature accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Feb 26, 2024
@ShGKme ShGKme added this to the 8.7.2 milestone Feb 26, 2024
@ShGKme ShGKme self-assigned this Feb 26, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 26, 2024

/backport to next

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

@susnux susnux merged commit 5436cd6 into master Feb 27, 2024
18 checks passed
@susnux susnux deleted the fix/NcActions--focus-selected-button-for-radio branch February 27, 2024 14:51
@Antreesy Antreesy mentioned this pull request Feb 29, 2024
@ShGKme ShGKme mentioned this pull request Feb 29, 2024
@ShGKme ShGKme modified the milestones: 8.7.2, 8.8.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants