Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(NcReferenceList): Resolve relative URLs before fetching references" #5291

Merged
merged 1 commit into from Feb 23, 2024

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Feb 22, 2024

This reverts #5272

Unfortunately it caused issues with Talk.

See the discussion in #5290 and #5272.

@mejo- mejo- added the 3. to review Waiting for reviews label Feb 22, 2024
…eferences"

This reverts commit 0b3f4ef.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Contributor Author

mejo- commented Feb 22, 2024

/backport to next

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please check if changes from 985c0fb (#5246) could cover your needs for the Text app

@juliushaertl juliushaertl merged commit 03be0d2 into master Feb 23, 2024
18 checks passed
@juliushaertl juliushaertl deleted the revert/reference_full_url branch February 23, 2024 18:53
@Antreesy Antreesy mentioned this pull request Feb 29, 2024
@ShGKme ShGKme mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants