fix: Center dashboard list items when there is no subtext #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
added
bug
5 tasks
ShGKme
approved these changes
Feb 20, 2024
susnux
approved these changes
Feb 20, 2024
|
Makes sense, but what if one element has subtext an the others not? |
susnux
added
4. to release
|
Also works the way of aligning works as before with the flex layout just that we center within the minimum height. |
|
/backport to next |
No I meant it more like if it makes sense to only align centered if all elements have no sub text. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have no subtext the title shall be centered to the image
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade