feat(NcAppContent): Allow to set the page title #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
raimund-schluessler,
JuliaKirschenheuter,
skjnldsv and
ShGKme
ShGKme
reviewed
Feb 20, 2024
ShGKme
reviewed
Feb 20, 2024
skjnldsv
reviewed
Feb 20, 2024
susnux
force-pushed
the
feat/allow-setting-page-title
branch
from
aa0f4bf
to
1181ddb
Compare
ShGKme
reviewed
Feb 20, 2024
susnux
force-pushed
the
feat/allow-setting-page-title
branch
from
5f8b7d9
to
c5f8dac
Compare
susnux
force-pushed
the
feat/allow-setting-page-title
branch
from
c5f8dac
to
d75d10a
Compare
ShGKme
approved these changes
Feb 29, 2024
ShGKme
requested changes
Feb 29, 2024
Sometimes - e.g. when you have multiple view - you want to adjust the page title, that is shown as the browsers tab name. This adds a property to set that value. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-setting-page-title
branch
from
d75d10a
to
62b6d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Sometimes - e.g. when you have multiple view - you want to adjust the page title, that is shown as the browsers tab name. This adds a property to set that value.
🏁 Checklist
nextrequested with a Vue 3 upgrade