revert: fix(NcActions): use new slots api

[ShGKme]

☑️ Resolves

• Fix Action menu on envelope and threads is broken nextcloud/mail#9282
• Reverts: fix(NcActions): use new slots api #5118

$scopedSlots cannot be used in beforeUpdated hook.

• On re-rendering, when vnode is reused, on beforeUpdated state $scopedSlots still returns an old value and breaks rendering.
• Officially, $slots/$scopedSlots should be used only during the rendering and not supposed to be used in data, computed or life cycle hooks.

This commit returns $slots to have an old behavior and resolve a regression

TODO: find a better solution to support both slots API. Use method in template and always call it, like we do in Vue 3?

🏁 Checklist

• ⛑️ Tests are included or are not applicable
• 📘 Component documentation has been extended, updated or is not applicable

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83d844d) 39.34% compared to head (08cc694) 39.34%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5196   +/-   ##
=======================================
  Coverage   39.34%   39.34%           
=======================================
  Files         139      139           
  Lines        3688     3688           
  Branches      810      810           
=======================================
  Hits         1451     1451           
  Misses       2021     2021           
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[susnux]

Also breaking Forms 🙈

[susnux]

Officially, $slots/$scopedSlots should be used only during the rendering and not supposed to be used in data, computed or life cycle hooks.

This also feels more natural to me, but not sure we can refactor like this. At least not non-breaking I guess.

[ShGKme]

This also feels more natural to me, but not sure we can refactor like this. At least not non-breaking I guess.

We can make text and isLongText methods and call them during the rendering. Then $scopedSlots in Vue 2 and $slots in Vue 3 will work fine. But it will have a small performance impact. These small slots will be rendered 3 times each rendering. Should be fine though (they just render a plain text).

An alternative could be a renderless component to cache a value during the rendering. This will work, but could be even less performant with an additional component instance =D

[ShGKme]

@susnux What do you think about #5197 ?

[susnux]

@susnux What do you think about #5197 ?

I think thats a viable solution 🎉
While I still think we should not have messed with the default slot, but if we do some special text handling, we should have required it to be passed as a prop.

[st3iny]

Thanks for the quick fix @ShGKme ♥️

[ShGKme]

Thanks for the quick fix @ShGKme ♥️

Sorry for the regression 🙈