Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcActions): hotfix for custom children #5185

Closed
wants to merge 2 commits into from
Closed

[next] fix(NcActions): hotfix for custom children #5185

wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 30, 2024

Backport of PR #5178

ShGKme and others added 2 commits January 30, 2024 17:11
@ShGKme @raimund-schluessler @backportbot
docs(NcActions): children limitations
6e66cde 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@ShGKme @raimund-schluessler @backportbot
fix(NcActions): hotfix for custom children
e87d513 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Co-authored-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components regression Regression of a previous working feature labels Jan 30, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jan 30, 2024

Not possible in Vue 3 for now. Requires a new way to find actions.

@ShGKme ShGKme closed this Jan 30, 2024
@susnux
Copy link
Contributor

susnux commented Jan 30, 2024

can we use inject/provide for a generic interface?

@ShGKme
Copy link
Contributor

ShGKme commented Jan 30, 2024

can we use inject/provide for a generic interface?

We will have the same issue we have now. inject doesn't happen until a component instance that injects something is created during the rendering. The same in render function, to have vnode.children we need to render vnode.

So we may need something like multi-stage rendering. I had some drafts yesterday, but dropped it to have a hotfix for a11y and Text app quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Awaiting requested review from Antreesy

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@susnux susnux Awaiting requested review from susnux

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShGKme @susnux