Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fields): adjust label line-height #5133

Merged
merged 1 commit into from Jan 25, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 25, 2024

Before, it had the same line-height in docs, but server has different styles.
See: #5132

Manually set the same line-height, which is the minimum allowed for a11y and was supposed to be set during development.

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Before it has the same line-height in docs, but server has different styles.
Manually set the same line-height, which is the minimum allowed for a11y.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Jan 25, 2024
@ShGKme ShGKme added this to the 8.5.1 milestone Jan 25, 2024
@ShGKme ShGKme self-assigned this Jan 25, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 25, 2024
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked text spacing and looks good ;)

@JuliaKirschenheuter JuliaKirschenheuter merged commit 4ca8762 into master Jan 25, 2024
15 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/5132/nc-field--label-position branch January 25, 2024 09:49
@susnux susnux mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NcInputField label overlaps with content
5 participants