-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed groupings in timezone picker #5130
fix: removed groupings in timezone picker #5130
Conversation
c00d9be
to
4c89169
Compare
Also - would love to have the opinion from all the reviewers. Would you personally leave the commented out code? This is a library, and so I am leaning on taking out the commented code (it was what was causing the problem in the first place), but due to the fact that we may later group the areas again, it MAY be used fr the logic of grouping areas (probably not, though, as all it does it create an object that NcSelect doesnt let you click on) |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
4c89169
to
b4e6166
Compare
In general I would remove it, otherwise we'd have a lot of commented code laying around just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than removing the commented code
+1 here. We always can re-take the code from history when it is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad, not we have no other easy solution with NcSelect for now
Thats why we use a version control system 😉 |
As I understand it, the problem was just about the constrast ratio, no? Why didn't we simply adjust the colors in the CSS of the picker? Or was there another issue that was not described? |
If I remember correctly, no. The main issue is about semantics. We cannot have groups only visually, where group is only defined by disabled and designed as a header list item. Groups have to be really a group with a header inside. cc @emoral435 @Pytal @JuliaKirschenheuter to clarify, if I'm wrong |
☑️ For nextcloud/server#41842
🖼️ Screenshots
🚧 Tasks
🏁 Checklist