Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between dark and light theme for NcDateTimePickerNative #4981

Merged
merged 1 commit into from Dec 20, 2023
Merged

Differentiate between dark and light theme for NcDateTimePickerNative #4981

merged 1 commit into from Dec 20, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

No changes for the light theme.
Screenshot from 2023-12-20 13-25-23

🏚️ Before 🏡 After
Screenshot from 2023-12-20 10-58-33 Screenshot from 2023-12-20 11-00-10

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 20, 2023
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 20, 2023
ShGKme
ShGKme approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and fixes the issue.

In future, I'd consider setting it globally so that:

  • All native elements would be dark on dark them and dark background
  • It would work also for not @nextcloud/vue elements
  • We won't need to fix it on all the places manually

input[type=number], select, scrollbars and ect.

@JuliaKirschenheuter @emoral435
Differentiate between dark and light theme for NcDateTimePickerNative
ac4e3a9 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@emoral435 emoral435 force-pushed the fix/42392-Create_possibility_to_change_a_color_theme_for_native_datetime_picker_on_dark_theme branch from 480841e to ac4e3a9 Compare December 20, 2023 17:10
emoral435
emoral435 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@emoral435 emoral435 merged commit c910776 into master Dec 20, 2023
15 checks passed
@emoral435 emoral435 deleted the fix/42392-Create_possibility_to_change_a_color_theme_for_native_datetime_picker_on_dark_theme branch December 20, 2023 17:22
@ShGKme ShGKme added bug Something isn't working accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 22, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments 😀

@ShGKme ShGKme added this to the 8.4.0 milestone Dec 22, 2023
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@emoral435 emoral435 emoral435 approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

[BITV]: Create possibility to change a color theme for native datetime picker on dark theme
3 participants
@JuliaKirschenheuter @ShGKme @emoral435