Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add small mobile breakpoint #4919

Merged
merged 2 commits into from Dec 6, 2023
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 5, 2023

☑️ Resolves

Used in #4909

This repo has several components with math.div($breakpoint-mobile, 2) media query. Similar to breakpoint-mobile it seems to be useful to have a SCSS variable for it and a composable to handle aka media-query change.

I called it small-mobile, but discussable for me.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews feature: functions composables, functions, mixins and other non-components labels Dec 5, 2023
@ShGKme ShGKme added this to the 8.4.0 milestone Dec 5, 2023
@ShGKme ShGKme self-assigned this Dec 5, 2023
@skjnldsv
Copy link
Contributor

skjnldsv commented Dec 6, 2023

I called it small-mobile

🚗.zip

@skjnldsv skjnldsv merged commit c899f87 into master Dec 6, 2023
15 checks passed
@skjnldsv skjnldsv deleted the feat/small-mobile-breakpoint branch December 6, 2023 18:01
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: functions composables, functions, mixins and other non-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants