Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAvatar): Increase contrast of avatar status icon #4912

Merged
merged 4 commits into from Dec 6, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Dec 5, 2023

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image image
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable

@Pytal Pytal added 3. to review Waiting for reviews feature: avatar Related to the avatar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 5, 2023
@Pytal Pytal added this to the 8.4.0 milestone Dec 5, 2023
@Pytal Pytal self-assigned this Dec 5, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 5, 2023

Doesn't it seem a bit too contrast on the light theme?
cc @nextcloud-libraries/designers

image

Dark Light
image image

@susnux
Copy link
Contributor

susnux commented Dec 5, 2023

Is it the contrast of the icon to the background? I read the issue as if the color of the status indicator does not have enough contrast meaning the green on the white.

image

So we should maybe adjust the SVGs for the status icons (and use the --color-success etc variables, this this possible?) as the our variables are tested to have high enough contrast.

@szaimen
Copy link
Contributor

szaimen commented Dec 5, 2023

So we should maybe adjust the SVGs for the status icons (and use the --color-success etc variables, this this possible?) as the our variables are tested to have high enough contrast.

yeah, this would be good if this fixes the problem :)

@Pytal Pytal force-pushed the fix/a11y/avatar-status-icons branch from 121e8b7 to 93d3ac2 Compare December 6, 2023 02:39
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@susnux susnux force-pushed the fix/a11y/avatar-status-icons branch 2 times, most recently from 356ab14 to e91080b Compare December 6, 2023 16:19
Pytal and others added 3 commits December 6, 2023 17:34
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/a11y/avatar-status-icons branch from e91080b to b93aeaa Compare December 6, 2023 16:34
@susnux susnux merged commit 86bfe29 into master Dec 6, 2023
16 checks passed
@susnux susnux deleted the fix/a11y/avatar-status-icons branch December 6, 2023 16:39
@ShGKme ShGKme added the bug Something isn't working label Dec 22, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Dec 22, 2023

Remember to add enhancement label for new features and bug for fixing bugs, including accessibility or adjustments πŸ˜€

@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants