Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Add a full labelled color palette to be used as the default for the color picker #4902

Merged
merged 1 commit into from Dec 8, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 1, 2023

☑️ Resolves

Lets provide a fully labelled color palette for the color picker by default.
When users provide a different palette its their task but for the default we can provide some color names (yes that are real color names for that colors).

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

…the color picker

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: colorpicker Related to the colorpicker component labels Dec 1, 2023
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be fun for the translators.

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux merged commit 7e67d12 into master Dec 8, 2023
16 checks passed
@susnux susnux deleted the enh/full-labelled-colors branch December 8, 2023 16:52
@susnux susnux added this to the 8.4.0 milestone Dec 8, 2023
ShGKme pushed a commit that referenced this pull request Dec 11, 2023
…olors

enh: Add a full labelled color palette to be used as the default for the color picker
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: colorpicker Related to the colorpicker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants