Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAvatar): remove alt attr from span[role=img] #4748

Merged
merged 1 commit into from Nov 2, 2023
Merged

fix(NcAvatar): remove alt attr from span[role=img] #4748

merged 1 commit into from Nov 2, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 2, 2023

☑️ Resolves

Error: Attribute alt not allowed on element span at this point.

Also, there is a description with aria-label.

🖼️ Screenshots

No visual changes

🚧 Tasks

  • Remove "alt" from user status span.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
fix(NcAvatar): remove alt attr from span[role=img]
4c66885 
ALT attribute is not valid on span and there is aria-label for labeling.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme self-assigned this Nov 2, 2023
@ShGKme ShGKme added bug Something isn't working feature: avatar Related to the avatar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 2, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Nov 2, 2023
@ShGKme ShGKme requested review from susnux, Pytal, JuliaKirschenheuter and szaimen and removed request for susnux November 2, 2023 11:49
@susnux susnux merged commit f1efe9c into master Nov 2, 2023
15 checks passed
@susnux susnux deleted the fix/avatar--remove-alt branch November 2, 2023 12:27
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@ShGKme ShGKme

Labels
accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @susnux @szaimen