Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSidebarTab): Ensure there is an aria-label if the aria-labelledby element does not exist #4736

Merged
merged 1 commit into from Nov 2, 2023
Merged

fix(NcSidebarTab): Ensure there is an aria-label if the aria-labelledby element does not exist #4736

merged 1 commit into from Nov 2, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 1, 2023

☑️ Resolves

If only one sidebar tab is shown, the tab header is missing. Thus we can not reference it for aria-labelledby and have to use aria-label instead.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Nov 1, 2023
@susnux susnux force-pushed the fix/ncappsidebar-tabs-labelled branch from 2279274 to db0f8c4 Compare November 1, 2023 21:21
@susnux susnux requested a review from ShGKme November 1, 2023 21:21
@susnux
fix(NcSidebarTab): Ensure there is an aria-label if the `aria-label…
386796d 
…ledby` element does not exist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/ncappsidebar-tabs-labelled branch from db0f8c4 to 386796d Compare November 2, 2023 01:26
@susnux susnux merged commit 5f3205f into master Nov 2, 2023
15 checks passed
@susnux susnux deleted the fix/ncappsidebar-tabs-labelled branch November 2, 2023 15:21
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV] "aria-labelledby" references an invalid element if there is a single tab
4 participants
@susnux @AndyScherzinger @JuliaKirschenheuter @ShGKme