feat(NcAppNavigationItem): Add active property to set active state & use aria-current
#4716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
raimund-schluessler,
JuliaKirschenheuter,
Pytal and
ShGKme
raimund-schluessler
approved these changes
Oct 30, 2023
|
Needs a rebase since #4715 is in. |
ShGKme
approved these changes
Oct 30, 2023
susnux
added
enhancement
…when not using `vue-router` Also set the `aria-current` attribute on the current active item Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/app-navigation-aria-current
branch
from
216f962
to
36adbdc
Compare
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
When not using
vue-routerit is currently not possible to set the current navigation item.Also in both cases the `aria-current´ attribute should be set.
🖼️ Screenshots
🏁 Checklist