Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppContent): Set normal scrollbar width on resizeable NcAppContentList #4710

Merged
merged 1 commit into from Nov 1, 2023

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Oct 28, 2023

When NcAppContentList is resizeable, a thin scrollbar is hard to catch with the mouse. Set scrollbar width to auto in this case.

Screenshots

Before (hover NcAppContentList) in Firefox/Linux After (hover NcAppContentList) in Firefox/Linux
2023-10-31T09:32:32,543502737+01:00 2023-10-31T09:31:27,365873640+01:00
Before (hover scrollbar of NcAppContentList) in Firefox/Linux After (hover scrollbar of NcAppContentList) in Firefox/Linux
2023-10-31T09:32:38,423200946+01:00 2023-10-31T09:30:52,494629227+01:00

In Chrome there's no visible change.

Please also see the screencast of the situation without this change in issue #4706.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

…entList

When `NcAppContentList` is resizeable, a thin scrollbar is hard to catch
with the mouse. Set scrollbar width to auto in this case.

Fixes: #4706

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added 3. to review Waiting for reviews design Design, UX, interface and interaction design accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: app-content-list Related to the app-content-list component labels Oct 28, 2023
@mejo-
Copy link
Contributor Author

mejo- commented Oct 28, 2023

/backport to stable7

@marcoambrosini
Copy link
Contributor

@mejo- Could you please post screenshots of FF and chrome? I'm testing this on Firefox and there's no difference in size if I add auto there.

@mejo-
Copy link
Contributor Author

mejo- commented Oct 31, 2023

@mejo- Could you please post screenshots of FF and chrome? I'm testing this on Firefox and there's no difference in size if I add auto there.

Sure! I added screenshots of before and later with Firefox/Linux now. The most remarkable change is when hovering the scrollbar (second table of screenshots).

In Chrome, there's no visible change.

Please also see the screencast of the situation without this change in issue #4706.

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@max-nextcloud max-nextcloud merged commit daaec86 into master Nov 1, 2023
15 checks passed
@max-nextcloud max-nextcloud deleted the fix/scrollbar_width_app_content_list branch November 1, 2023 19:10
@skjnldsv skjnldsv added the bug Something isn't working label Nov 3, 2023
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 3, 2023

Please set appropriate bug or enhancement labels next time 👍

@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working design Design, UX, interface and interaction design feature: app-content-list Related to the app-content-list component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar of NcAppContentList hard to catch with resizable columns
5 participants