Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header prop to NcRelatedResourcesPanel #4703

Merged
merged 1 commit into from Oct 27, 2023
Merged

Add header prop to NcRelatedResourcesPanel #4703

merged 1 commit into from Oct 27, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 27, 2023 •
edited

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A
related_before Screenshot from 2023-10-27 14-33-16

🚧 Tasks

  • There are many ways how to do this, but for now we only need the app header to be dynamic so each one of the apps can add their own.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@GretaD
Add header prop
74314a1 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Oct 27, 2023
@GretaD GretaD self-assigned this Oct 27, 2023
@ChristophWurst ChristophWurst changed the title Add header prop Add header prop to NcRelatedResourcesPanel Oct 27, 2023
@GretaD GretaD requested review from ShGKme and Fenn-CS October 27, 2023 13:17
@GretaD GretaD merged commit 1a58f2a into master Oct 27, 2023
15 checks passed
@GretaD GretaD deleted the feat/add-header branch October 27, 2023 13:30
@raimund-schluessler raimund-schluessler mentioned this pull request Oct 27, 2023
Merged
@szaimen
Copy link
Contributor

szaimen commented Oct 27, 2023

What happened here?
image

@GretaD
Copy link
Contributor Author

GretaD commented Oct 27, 2023 •
edited

looks like my lint:fix likes it that way

@szaimen
Copy link
Contributor

szaimen commented Oct 27, 2023 •
edited

I see but weird

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 3, 2023 •
edited

Please set appropriate bug or enhancement labels next time 👍

@skjnldsv skjnldsv added enhancement New feature or request feature: related resources panel Related to the NcRelatedResourcesPanel component labels Nov 3, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request feature: related resources panel Related to the NcRelatedResourcesPanel component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GretaD @szaimen @skjnldsv @ChristophWurst @ShGKme