feat(NcIconSvgWrapper)!: remove ID from svg #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Note: arria-hidden="false" doesn't add an attribute in Vue 2, but does in Vue 3. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
3. to review
ShGKme
requested review from
susnux,
raimund-schluessler,
JuliaKirschenheuter,
skjnldsv,
Pytal and
szaimen
ShGKme
commented
Oct 4, 2023
Comment on lines
+123
to
+131
| /** | ||
| * By default MDI icons have an ID on the `<svg>` element. It leads to dupliated IDs on a web-page. | ||
| * This component removes the ID on the received SVG. | ||
| * Use this prop to disable this behavior and to not remove the ID. | ||
| */ | ||
| keepId: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, |
There was a problem hiding this comment.
I do not think this is needed
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
feat/nc-icon-svg-wrapper-remove-svg-id
branch
from
bfc09c0
to
8e92ce1
Compare
10 tasks
skjnldsv
approved these changes
Oct 4, 2023
susnux
approved these changes
Oct 4, 2023
skjnldsv
changed the title
ShGKme
added
4. to release
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
All material design icons from
@mdihave ID attribute. It seems to be used by material design icons for web-font generation, but not needed in our apps and creates multiple duplicated IDs.This PR removes the ID using DOM parser.
🖼️ Screenshots
🚧 Tasks
keepIdprop to have a possibility to keep the ID (is it unneeded?)aria-labelandaria-hidden="false" Vue 3attributes🏁 Checklist