Bring back label outside of the input for NcActionInput #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield In previous versions the label was shown above the input which gives the text more space which might be better than the inline label from #4394 in some scenarios. This is a breaking change as it renames the previous labelVisible property to a labelOutside property. The label should always be visible with the new NcInputField, however we can optionally decide to have the label outside. Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/ncactioninput-label-outside
branch
from
fe4f363
to
d0fcc24
Compare
juliushaertl
requested review from
susnux,
raimund-schluessler,
Pytal and
max-nextcloud
ShGKme
approved these changes
Aug 30, 2023
juliushaertl
added
enhancement
Pytal
approved these changes
Aug 30, 2023
Pytal
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4394 introduced a change that having the label outside of the input is no longer possible with NcActionItem
Found in nextcloud/text#4663
🖼️ Screenshots
7.x.x with label-visible
Current 8.0.0-beta.with label-visible
This PR with label-outside
🏁 Checklist