Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable7] NcRichContenteditable: fix IME support on Mac OSX #4322

Merged
merged 2 commits into from Jul 12, 2023
Merged

[stable7] NcRichContenteditable: fix IME support on Mac OSX #4322

merged 2 commits into from Jul 12, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 11, 2023

Manual backport of #4294

This backport includes backporting of 730dcb7

ShGKme and others added 2 commits July 11, 2023 15:31
@ShGKme @skjnldsv
fix: jest config
3614945 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> 

Co-authored-by: John Molakvoæ <skjnldsv@protonmail.com>
@ShGKme
fix(NcRichContenteditable): fix IME support
60c8790 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components labels Jul 11, 2023
@ShGKme ShGKme added this to the 7.11.7 milestone Jul 11, 2023
@ShGKme ShGKme self-assigned this Jul 11, 2023
Antreesy
Antreesy approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭
Should works the same as on master branch, but couldn't test it with Mac

Antreesy

This comment was marked as duplicate.

Sign in to view

@susnux susnux merged commit a5b981b into stable7 Jul 12, 2023
17 checks passed
@susnux susnux deleted the backport/4294/stable7 branch July 12, 2023 14:34
@susnux susnux mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
7.11.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @susnux @Antreesy