Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set double outline to buttons in focus state #4319

Merged
merged 1 commit into from Jul 12, 2023
Merged

Set double outline to buttons in focus state #4319

merged 1 commit into from Jul 12, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jul 10, 2023 •
edited

☑️ Resolves

🖼️ Screenshots

🏚️ Before
image

🏡 After

Screenshot from 2023-07-10 16-00-16
Screenshot from 2023-07-10 15-59-28
Screenshot from 2023-07-10 15-41-07
Screenshot from 2023-07-10 15-36-30
Screenshot from 2023-07-10 10-32-22
Screenshot from 2023-07-10 10-31-43
Screenshot from 2023-07-04 09-04-14
Screenshot from 2023-07-03 17-42-59
Screenshot from 2023-07-03 17-27-30
Screenshot from 2023-07-03 17-19-16
Screenshot from 2023-07-10 16-15-58
Screenshot from 2023-07-10 16-15-31

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jul 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jul 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the base branch from master to stable7 July 10, 2023 14:09
@JuliaKirschenheuter
Copy link
Contributor Author

needed to be merged in master too

@JuliaKirschenheuter JuliaKirschenheuter changed the title Fix/41930 buttons accessibility improvements Set double outline to buttons in focus state Jul 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jul 11, 2023
Merged
4 tasks
@JuliaKirschenheuter
Copy link
Contributor Author

how could i get DCO be green? ;)

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jul 11, 2023
Merged
@JuliaKirschenheuter @susnux
Set double outline to buttons in focus state
ba71310 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@susnux susnux force-pushed the fix/41930-Buttons_accessibility_improvements branch from 89b3c8d to ba71310 Compare July 12, 2023 13:06
@JuliaKirschenheuter JuliaKirschenheuter merged commit 715b6d5 into stable7 Jul 12, 2023
16 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/41930-Buttons_accessibility_improvements branch July 12, 2023 14:42
@susnux susnux mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV] Buttons accessibility improvements [BITV] 9.1.4.1/3.1 - Styling menubar - active contrast
6 participants
@JuliaKirschenheuter @susnux @artonge @Pytal @marcoambrosini @nimishavijay