Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NcPopover - make corners round #4229

Closed
wants to merge 2 commits into from
Closed

NcPopover - make corners round #4229

wants to merge 2 commits into from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 17, 2023 •
edited

Close #4230

Before After
image image

@szaimen szaimen added the 2. developing Work in progress label Jun 17, 2023
@szaimen szaimen added this to the 8.0.0 milestone Jun 17, 2023
@szaimen szaimen force-pushed the enh/noid/make-rounded-corners branch 2 times, most recently from 3b0a67d to e6ab137 Compare June 17, 2023 18:07
@szaimen
Copy link
Contributor Author

szaimen commented Jun 17, 2023

/backport to stable7

@szaimen szaimen marked this pull request as ready for review June 17, 2023 18:10
@szaimen szaimen added 3. to review Waiting for reviews design Design, UX, interface and interaction design and removed 2. developing Work in progress labels Jun 17, 2023
@szaimen szaimen requested review from jancborchardt, raimund-schluessler, marcoambrosini, nimishavijay, a team, susnux, Fenn-CS and Pytal and removed request for a team June 17, 2023 18:11
@szaimen
NcPopover - make corners round
80e4db8 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/make-rounded-corners branch from e6ab137 to 80e4db8 Compare June 17, 2023 18:12
@raimund-schluessler
Copy link
Contributor

See #4017

@szaimen
fix the examples
6fa5bcc 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Jun 17, 2023

Ah nice, thanks! :)

@szaimen szaimen closed this Jun 17, 2023
@szaimen szaimen deleted the enh/noid/make-rounded-corners branch June 17, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request design Design, UX, interface and interaction design
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

usermenu needs rounded corners
2 participants
@szaimen @raimund-schluessler