Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve NcSettingsSelectGroup - Convert to NcSelect #4120

Merged
merged 4 commits into from Jun 22, 2023
Merged

Improve NcSettingsSelectGroup - Convert to NcSelect #4120

merged 4 commits into from Jun 22, 2023

Commits on May 31, 2023

  1. feat(NcSettingsSelectGroup): Adding documentation, move to NcSelect a… 

    …nd drop unused property

* Moved from deprecated `NcMultiselect` to `NcSelect`
* Removed unused `hint` property
* Added `placeholder` property and added a hidden label element
  The `label` property is still used for the placeholder for backwards compatibility.
* Added documentation for the events and added an example

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e86085f View commit details
    Browse the repository at this point in the history

  2. feat(docs): Add axios mocking for the documentation to allow examples… 

    … of the `NcSettingsSelectGroup`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 31, 2023
    Configuration menu
    Copy the full SHA
    dacbabc View commit details
    Browse the repository at this point in the history

  3. fear(NcSettingsSelectGroup): Reduce API calls for loading groups 

    * Debounce search requests when typing
* Cache initial groups (empty search) for all components of current page

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 31, 2023
    Configuration menu
    Copy the full SHA
    46c7eef View commit details
    Browse the repository at this point in the history

  4. feat(NcSettingsSelectGroup): Filter by display name *and* id of group 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 31, 2023
    Configuration menu
    Copy the full SHA
    227134b View commit details
    Browse the repository at this point in the history