Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow preventing link insertion in RichContentEditable #3890

Merged
merged 1 commit into from Nov 1, 2023
Merged

Allow preventing link insertion in RichContentEditable #3890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/components/NcRichContenteditable/NcRichContenteditable.vue
View file
Open in desktop
Expand Up @@ -337,6 +337,7 @@ export default {
'submit',
'paste',
'update:value',
'smart-picker-submit',
],

data() {
Expand Down Expand Up @@ -585,21 +586,30 @@ export default {
// there is no way to get a tribute result asynchronously
// so we immediately insert a node and replace it when the result comes
getLinkWithPicker(item.original.id)
.then(link => {
// replace dummy temp element by a text node which contains the link
const tmpElem = document.getElementById('tmp-link-result-node')
const newElem = document.createTextNode(link)
tmpElem.replaceWith(newElem)
this.setCursorAfter(newElem)
this.updateValue(this.$refs.contenteditable.innerHTML)
.then(result => {
// replace dummy temp element by a text node which contains the picker result
const tmpElem = document.getElementById('tmp-smart-picker-result-node')
const eventData = {
result,
insertText: true,
}
this.$emit('smart-picker-submit', eventData)
if (eventData.insertText) {
const newElem = document.createTextNode(result)
tmpElem.replaceWith(newElem)
this.setCursorAfter(newElem)
this.updateValue(this.$refs.contenteditable.innerHTML)
} else {
tmpElem.remove()
}
})
.catch((error) => {
console.debug('Smart picker promise rejected:', error)
const tmpElem = document.getElementById('tmp-link-result-node')
const tmpElem = document.getElementById('tmp-smart-picker-result-node')
this.setCursorAfter(tmpElem)
tmpElem.remove()
})
return '<span id="tmp-link-result-node"></span>'
return '<span id="tmp-smart-picker-result-node"></span>'
},
setCursorAfter(element) {
const range = document.createRange()
Expand Down