Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, this library conflicts with the current
@nextcloud/webpack-vue-config
v5.5.0.It provides only cjs module that consider Vue package to be cjs as well.
But apps (at least Talk) mostly uses esm by default.
@nextcloud/webpack-vue-config
v5.4.0. An old config just built an app with both esm and cjs vue copies in the bundle. But in v5.5.0 there was added resolve alias for vue. It results with using only one Vue package in the built and helps to get rid of multiple Vue on the page. At the same time, it broke building an app with this library, providing wrong Vue module type.This PR:
esm
to build targetsexports
field topackage.json
providing proper entrypoint to each module typemodule
field topackage.json
as a fallback for all tools not supportingexports
library
field frompackage.json
(I have found no mentions about this field. Neither in npm docs, nor in nodejs or webpack/vite docs...global
settings from rollup config. It is not required if we don't built iife / umd with global Vue.vue
fromdependencies
topeerDependencies
as it is a peer by design.@nextcloud/vue
duplication frompeerDependencies
.Related: nextcloud/spreed#9236