fix: import locales and moment instead of moment-with-locales #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
reviewed
Jan 23, 2024
|
True, doesn't work in Forms.. |
ShGKme
force-pushed
the
fix/import-moment-with-locales
branch
2 times, most recently
from
2c86fbb
to
e5d9674
Compare
ShGKme
force-pushed
the
fix/import-moment-with-locales
branch
from
e5d9674
to
79c12e9
Compare
ShGKme
commented
Jan 23, 2024
susnux
reviewed
Jan 23, 2024
|
It is more complicated than to fix on the I haven't found an easier solution, tried different moment dists, tried to play with disabling optimization. import.meta.glob doesn't work with packages. The PR with a fix in the webpack config is ready for review as well, I'm fine with any way. |
|
Sorry, not my level of code understanding :( |
moment-with-locales doesn't work in Webpack due to invalid unused require Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/import-moment-with-locales
branch
from
79c12e9
to
8e5f77a
Compare
|
Closing in flavor of nextcloud-libraries/webpack-vue-config#533 No issues now with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moment/min/moment-with-locales.jsworks only in Node.js and is not compatible with Webpack bundling. It has an unused functionlocalLocalethat requires locales by invalid relative path./locale. Though it is not used, Webpack tries to resolve it withrequire.contextand fails.Example of issue in Talk, same in Text and other apps:
The current solution via Vite plugin manually import all the locales from ES modules from
distand importsmomentfrom the samedistwith ESMs. Each module defines locale in thismoment.Alternative to:
./localeimport frommoment/min/moment-with-localeswebpack-vue-config#533See also:
moment/min/moment-with-locales.js: https://github.com/moment/moment/blob/develop/min/moment-with-locales.js#L2159