Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): various typings and owner string cast #882

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Feb 3, 2024

Owner can be transformed to a number by the webdav lib if it's only digits...
Also changed a few other typings to ensure we don't rely on inline types (we would have caught this sooner)

@skjnldsv skjnldsv added bug Something isn't working 3. to review labels Feb 3, 2024
@skjnldsv skjnldsv requested a review from susnux February 3, 2024 11:37
@skjnldsv skjnldsv self-assigned this Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4c2e5ba) 77.75% compared to head (1241439) 77.50%.

Files Patch % Lines
lib/dav/dav.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   77.75%   77.50%   -0.26%     
==========================================
  Files          17       17              
  Lines         436      440       +4     
  Branches      116      118       +2     
==========================================
+ Hits          339      341       +2     
- Misses         97       98       +1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit c4fe83c into master Feb 3, 2024
13 of 15 checks passed
@skjnldsv skjnldsv deleted the fix/typing branch February 3, 2024 12:11
@susnux
Copy link
Contributor

susnux commented May 21, 2024

This broke the file picker for public shares, as the user id is not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants