Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not update mtime if not already defined #709

Merged
merged 1 commit into from Jul 28, 2023
Merged

fix: do not update mtime if not already defined #709

merged 1 commit into from Jul 28, 2023

Conversation

skjnldsv
Copy link
Contributor

Context:

  1. In the files app, have a list of node with unknown mtime
  2. the mtime column is hidden
  3. have an action updating a Node attribute
  4. the mtime column suddenly appear because at least one node now have a valid mtime

Correct behaviour:

  • the mtime column stays hidden and the mtime stays undefined

@skjnldsv
fix: do not update mtime if not already defined
8f072ec 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review labels Jul 27, 2023
@skjnldsv skjnldsv requested a review from susnux July 27, 2023 14:34
@skjnldsv skjnldsv self-assigned this Jul 27, 2023
@susnux susnux merged commit 4d4bf49 into master Jul 28, 2023
8 checks passed
@susnux susnux deleted the fix/mtime branch July 28, 2023 13:47
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skjnldsv @susnux