Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FilePicker): Stop click event on checkbox column to allow multiselect #1192

Merged
merged 1 commit into from Jan 18, 2024
Merged

fix(FilePicker): Stop click event on checkbox column to allow multiselect #1192

merged 1 commit into from Jan 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 18, 2024

This changes two things:

  1. The click event on the whole checkbox column is stopped from bubbling
  2. Only add the click listener if required, same as the keyboard listener

@susnux susnux added bug Something isn't working 3. to review labels Jan 18, 2024
@susnux
fix(FilePicker): Stop click event on checkbox column to allow multise…
3908ba9 
…lect

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit 7d3a052 into main Jan 18, 2024
10 checks passed
@skjnldsv skjnldsv deleted the fix/stop-click-event branch January 18, 2024 07:45
@susnux susnux mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't pick directory in Dialog
2 participants
@susnux @skjnldsv