Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): Improve choose button text when selecting multiple #1191

Merged
merged 1 commit into from Jan 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 18, 2024

Instead of only showing Choose FIRST FILE or just Choose show Choose 3 files when multiselect is enabled.

@susnux susnux added enhancement New feature or request 3. to review labels Jan 18, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@come-nc
Copy link

come-nc commented Jan 18, 2024

But it also change Choose FIRST FILE to Choose 1 file, no? Is that ok?

@come-nc
Copy link

come-nc commented Jan 18, 2024

But it also change Choose FIRST FILE to Choose 1 file, no? Is that ok?

Nope, my bad, it does not. It’s weird that the multiversions has plural and singular but I suppose it’s needed for other languages.

@susnux
Copy link
Contributor Author

susnux commented Jan 18, 2024

Nope, my bad, it does not. It’s weird that the multiversions has plural and singular but I suppose it’s needed for other languages.

yes there are languages with more plural forms

@susnux susnux merged commit 5d73c78 into main Jan 18, 2024
10 checks passed
@susnux susnux deleted the fix/improve-choose-button branch January 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants