Remove unneeded tab, tablist and aria-selected roles from navigation
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
approved these changes
Jan 17, 2024
JuliaKirschenheuter
force-pushed
the
fix/42599-dialogs-remove-unneeded-attrs-from-nav
branch
from
33d59fa
to
8cf2be6
Compare
emoral435
approved these changes
Jan 17, 2024
emoral435
force-pushed
the
fix/42599-dialogs-remove-unneeded-attrs-from-nav
branch
from
8cf2be6
to
4d1f66f
Compare
susnux
approved these changes
Jan 17, 2024
…ation Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
susnux
force-pushed
the
fix/42599-dialogs-remove-unneeded-attrs-from-nav
branch
from
4d1f66f
to
089db9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏚️ Before | 🏡 After
No visual changes. Result: no errors through automatically a11y tests.