Remove aria-label from <div>
#1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
added
3. to review
accessibility
JuliaKirschenheuter
requested review from
susnux,
artonge,
Pytal,
ShGKme and
emoral435
artonge
approved these changes
Jan 17, 2024
ShGKme
approved these changes
Jan 17, 2024
JuliaKirschenheuter
force-pushed
the
fix/42626-remove_attr_on_wrong_element
branch
from
43b7723
to
f995fbc
Compare
emoral435
approved these changes
Jan 17, 2024
susnux
approved these changes
Jan 17, 2024
emoral435
force-pushed
the
fix/42626-remove_attr_on_wrong_element
branch
from
f995fbc
to
4108024
Compare
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
susnux
force-pushed
the
fix/42626-remove_attr_on_wrong_element
branch
from
4108024
to
7c817c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not allowed to put
aria-labelnot on the interactive elements.Besides this such text isn't nice for screen reader like: "MIME type httpd/unix-directory", "MIME type image/png", "MIME type text/markdown". Would be much better to have just "folder", "document", "image". Some kind of mapping can be done in future (it is not mandatory). For now removing wrong attribute: nextcloud/server#42626 (comment)