Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust types for IFilePickerButton to align icon with NcDialogButton #1122

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: Adjust types for IFilePickerButton to align icon with NcDialogButton #1122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/components/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
*/

import type { Node } from '@nextcloud/files'
import type { AsyncComponent, Component } from 'vue'

/**
* Interface for defining buttons passed to the Dialog component
Expand All @@ -33,11 +32,12 @@

/** Callback on button click */
callback: () => void,

Check warning on line 35 in lib/components/types.ts

View check run for this annotation

Codecov / codecov/patch

lib/components/types.ts#L35 

Added line #L35 was not covered by tests
/**
* Optional Icon for the button
* Can be a Vue component, async Vue component, or SVG
* Should be a SVG image as raw string

Check warning on line 38 in lib/components/types.ts

View check run for this annotation

Codecov / codecov/patch

lib/components/types.ts#L38 

Added line #L38 was not covered by tests
*/
icon?: Component | AsyncComponent | string,
icon?: string,

Check warning on line 40 in lib/components/types.ts

View check run for this annotation

Codecov / codecov/patch

lib/components/types.ts#L40 

Added line #L40 was not covered by tests

/**
* Button type
Expand Down