Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load user config for each previews #1108

Merged
merged 1 commit into from Nov 15, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 15, 2023

No description provided.

@artonge artonge requested a review from susnux November 15, 2023 11:41
@artonge artonge self-assigned this Nov 15, 2023
@artonge artonge force-pushed the artonge/perf/user_config_for_previews branch from 8161d4b to 1d7c662 Compare November 15, 2023 11:48
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (318d22c) 30.49% compared to head (1d7c662) 30.49%.

❗ Current head 1d7c662 differs from pull request most recent head 53cf1b8. Consider uploading reports for the commit 53cf1b8 to get more accurate results

Files Patch % Lines
lib/composables/filesSettings.ts 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1108   +/-   ##
=======================================
  Coverage   30.49%   30.49%           
=======================================
  Files          16       16           
  Lines        1223     1223           
  Branches       60       60           
=======================================
  Hits          373      373           
  Misses        792      792           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/perf/user_config_for_previews branch from 1d7c662 to 53cf1b8 Compare November 15, 2023 11:56
@artonge artonge merged commit a1557c8 into main Nov 15, 2023
9 checks passed
@artonge artonge deleted the artonge/perf/user_config_for_previews branch November 15, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants